[FIRRTL] Replace remove-unused-ports with port-only IMDCE mode#10575
Open
uenoku wants to merge 1 commit into
Open
[FIRRTL] Replace remove-unused-ports with port-only IMDCE mode#10575uenoku wants to merge 1 commit into
uenoku wants to merge 1 commit into
Conversation
uenoku
force-pushed
the
dev/hidetou/remove-unused-ports
branch
from
df39e83 to
85c55f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces RemoveUnusedPorts with IMDCE by adding a new mode to IMDCE as mentioned in #10501.
To mimic the old RemoveUnusedPorts behavior, this PR adds two options (1) dropping donttouch (2) remove only ports. Maybe it might be better to move (1) to reduction pattern instead of implementing in IMDCE pass, though.
Invalid value propagation is added as well to pass the old test.
This PR fixes crashes in #10501 and #10504. IMDCE doesn't eliminate property/instance choices at this point though.
Close #3377.
Assisted-by: claude code: sonnet 4.6