Conversation
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
🚀 Deployed on https://deploy-preview-2798--wai-aria.netlify.app |
adampage
reviewed
May 28, 2026
spectranaut
approved these changes
May 28, 2026
Contributor
spectranaut
left a comment
spectranaut
left a comment
There was a problem hiding this comment.
This looks good to me, and I think it does help solve the reported issue. I agree with all of @adampage's requests for changes/clarity, if they are possible :)
…-link Role Attribute spec - Restore <code>role</code> inside all <a>role attribute</a> link references throughout the document, per adampage's review suggestions - Deep-link the Role Attribute 1.0 spec reference to the specific #s_role_module_attributes section Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jnurthen
changed the title
adampage
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Netlify Preview:
🔄 this PR updates the following sspecs:
Closes #2145,
export attr-role, MUST allow, glossary data-noexport, role-attribute term linking.
related work: whatwg/html#6890.
And a few other todo items (delete this section after performing them):
spec:<spec_name>label. If you don't have privileges to do this, editors will do it for you.Test, Documentation and Implementation tracking
Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.