fix: add missing dependency#1011
Open
clemyan wants to merge 1 commit into
Open
Conversation
The `eslint-plugin-vue` has a peer dependency on `vue-eslint-parser` but the generated `package.json` does not list it as a dependency
Contributor
|
To provide a little more background on the underlying issue... I believe this change is intended to fix linting with Yarn. I could reproduce the problem fairly readily with the latest Yarn (4.15.0) and a I posted a full reproduction here: That reproduction is using workspaces, though they aren't needed to reproduce this issue with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
eslint-plugin-vuehas a peer dependency onvue-eslint-parserbut the generatedpackage.jsondoes not list it as a dependency.I have added the
vue-eslint-parseras a devDependency in the template.