Various small stuff#373
Merged
Merged
Conversation
If argc is not at least 1, we'll be in undefined behaviour land when we do argv[0] and argc can indeed be 0 with an empty argv if we are launched by some other application.
…tatic std::uint8_t reads better as "raw bytes" than "unsigned char" (IMHO). Add constexpr since this is a fixed compile-time array. Remove static; static gives each translation unit its own private copy (internal linkage, not what we want), while inline ensures a single ODR-shared entity across translation units (what we want).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.