Editorial: Replace ASCII quotes with typographic quotes as appropriate#3861
Open
gibson042 wants to merge 2 commits into
Open
Editorial: Replace ASCII quotes with typographic quotes as appropriate#3861gibson042 wants to merge 2 commits into
gibson042 wants to merge 2 commits into
Conversation
gibson042
added
editorial change
editor call
|
The rendered spec preview for this PR is available as a single page at https://tc39.es/ecma262/pr/3861 and as multiple pages at https://tc39.es/ecma262/pr/3861/multipage . |
gibson042
commented
May 15, 2026
Comment on lines
-3231
to
3232
| <li>[[Type]] = ~normal~, [[Target]] = ~empty~, and [[Value]] = a value of the "normal return type" shown below for that internal method, or</li> | ||
| <li>[[Type]] = ~normal~, [[Target]] = ~empty~, and [[Value]] = a value of the “normal return type” shown below for that internal method, or</li> | ||
| <li>[[Type]] = ~throw~, [[Target]] = ~empty~, and [[Value]] = any ECMAScript language value.</li> |
Member
Author
There was a problem hiding this comment.
Quotation changes aside, the equals signs in this text don't look right to me. I think some refactoring would improve it.
michaelficarra
force-pushed
the
gh-3860-typographic-quotes
branch
from
c77ec10 to
77d00d6
Compare
michaelficarra
requested changes
May 16, 2026
Member
michaelficarra
left a comment
michaelficarra
left a comment
There was a problem hiding this comment.
Please drop the first commit.
When _referencing_ `?` and `!` (as opposed to _using_ them), enclose them in typographic quotes rather than backticks. Using quotes aligns with editorial conventions (albeit inconsistently applied), while using backticks makes them render as if they were [grammar terminal symbols](https://tc39.es/ecma262/multipage/notational-conventions.html#sec-terminal-symbols).
gibson042
force-pushed
the
gh-3860-typographic-quotes
branch
from
77d00d6 to
d6c9562
Compare
Member
Author
Done. |
linusg
approved these changes
May 28, 2026
Member
linusg
left a comment
linusg
left a comment
There was a problem hiding this comment.
Fine by me with a preference for automated linting if feasible - easy to forget and not easy to catch depending on the font.
michaelficarra
approved these changes
May 28, 2026
Member
michaelficarra
left a comment
michaelficarra
left a comment
There was a problem hiding this comment.
There's some quotes that can just be dropped, but this is an improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3859, because I noticed the issue while fixing #3858.
Fixes #3860