Skip to content

Just use radius for activate change camera_tv#5637

Open
LLS-lopos wants to merge 19 commits into
supertuxkart:masterfrom
LLS-lopos:master
Open

Just use radius for activate change camera_tv#5637
LLS-lopos wants to merge 19 commits into
supertuxkart:masterfrom
LLS-lopos:master

Conversation

@LLS-lopos
Copy link
Copy Markdown
Contributor

Agreement

By creating a pull request in stk-code, you hereby agree to dual-license your contribution as
GNU General Public License version 3 or any later version and
Mozilla Public License version 2 or any later version.

This includes your previous contribution(s) under the same name of contributor.

Keep the above statement in the pull request comment for agreement.

I follow the principle of other types of cameras:
parameter "start" for the radius

@LLS-lopos
Copy link
Copy Markdown
Contributor Author

@Alayan-stk-2
Copy link
Copy Markdown
Member

I think I don't quite understand the reasoning behind the change here. The radius approach may make sense for end-race cameras, but the needs for the soccer cameras are quite different.

This won't fix the issue of picking a camera that's looking "the wrong way", is it? Or picking a camera that's too close to the ball?

By looking the wrong way, I mean for example that the ball is moving towards a goal and the game picks a camera that looks from the goal towards the outside instead of a camera looking from the middle of the field towards the center.

And if I understand correctly it also requires an update to the fields adding custom radius values for all of the soccer cameras, as you've linked new soccer field zips.

@LLS-lopos
Copy link
Copy Markdown
Contributor Author

LLS-lopos commented Mar 5, 2026

It now checks which camera to use based on the viewing angle of the active camera.
If the camera angle is less than the defined value (if too close to the active camera), it switches to the active camera.
@Alayan-stk-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants