Skip to content

fix: add light mode support to Footer component#855

Open
Hitesh3936 wants to merge 2 commits into
sugarlabs:mainfrom
Hitesh3936:fix/footer-light-mode
Open

fix: add light mode support to Footer component#855
Hitesh3936 wants to merge 2 commits into
sugarlabs:mainfrom
Hitesh3936:fix/footer-light-mode

Conversation

@Hitesh3936
Copy link
Copy Markdown

Fixes #835

Changes Made

  • Added light mode styles to footer background using bg-gray-50
  • Added dark: variants to preserve existing dark mode design
  • Fixed text contrast for light mode on headings and body text
  • Fixed social icons to only invert in dark mode
  • Updated borders, buttons, and info box for light mode compatibility

Testing

  • Tested locally in both light and dark mode
  • No visual regression in dark mode
  • Footer now matches the rest of the UI in light mode

@github-actions
Copy link
Copy Markdown

❌ Checks Failed

Status: 🚫 Not ready to merge

Please fix the following issues before merging:

📝 Code Linting Failed

Issue: Code formatting or style violations detected.

Specific problems:

• Code formatting issues detected

How to fix:

Platform Command Description
🐧 Unix/macOS/Linux npm run format Auto-fix all formatting issues
🪟 Windows npm run format:file <filename> Fix specific files
🔍 Check Only npm run format:check Check formatting without fixing

Need help with linting? Check out the Linting Guide for Windows Users for detailed instructions.


🛠️ Next Steps

  1. Fix the issues mentioned above
  2. Test locally to ensure everything works
  3. Push your fixes to this branch
  4. Wait for re-check - This bot will automatically run again

🤖 This comment will be updated automatically when you push new commits

@github-actions
Copy link
Copy Markdown

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Footer does not support light mode

1 participant