Skip to content

feat(intake): refactor wait handler to use helper struct#7163

Merged
GokceGK merged 27 commits into
mainfrom
feat/STACKITSDK-375-intake-refactor-wait-handler
Jun 3, 2026
Merged

feat(intake): refactor wait handler to use helper struct#7163
GokceGK merged 27 commits into
mainfrom
feat/STACKITSDK-375-intake-refactor-wait-handler

Conversation

@GokceGK
Copy link
Copy Markdown
Contributor

@GokceGK GokceGK commented May 6, 2026

Description

relates to STACKITSDK-375

Checklist

  • Issue was linked above
  • No generated code was adjusted manually (check comments in file header)
  • Changelogs
    • Changelog in the root directory was adjusted (see here)
    • Changelog(s) of the service(s) were adjusted (see e.g. here)
  • VERSION file(s) of the service(s) were adjusted
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@GokceGK GokceGK requested a review from a team as a code owner May 6, 2026 09:20
@rubenhoenle
Copy link
Copy Markdown
Member

rubenhoenle commented May 6, 2026

One nitpick regarding the commit message:

- feat (intake): refactor wait handler to use helper struct
+ feat(intake): refactor wait handler to use helper struct

rubenhoenle
rubenhoenle reviewed May 6, 2026
View reviewed changes
Comment thread services/intake/VERSION Outdated
rubenhoenle
rubenhoenle reviewed May 13, 2026
View reviewed changes
Comment thread services/intake/v1betaapi/wait/wait.go
rubenhoenle
rubenhoenle reviewed May 13, 2026
View reviewed changes
Comment thread services/intake/v1betaapi/wait/wait.go
rubenhoenle
rubenhoenle reviewed May 13, 2026
View reviewed changes
Comment thread services/intake/v1betaapi/wait/wait.go
rubenhoenle
rubenhoenle reviewed May 15, 2026
View reviewed changes
Comment thread services/intake/v1betaapi/wait/wait_test.go Outdated
@rubenhoenle rubenhoenle changed the title feat (intake): refactor wait handler to use helper struct feat(intake): refactor wait handler to use helper struct May 15, 2026
@GokceGK GokceGK enabled auto-merge (squash) May 19, 2026 11:13
@rubenhoenle rubenhoenle mentioned this pull request May 19, 2026
Merged
11 tasks
rubenhoenle
rubenhoenle reviewed May 29, 2026
View reviewed changes
Comment thread CHANGELOG.md Outdated
rubenhoenle
rubenhoenle previously approved these changes May 29, 2026
View reviewed changes
@GokceGK GokceGK merged commit 129972b into main Jun 3, 2026
7 checks passed
@GokceGK GokceGK deleted the feat/STACKITSDK-375-intake-refactor-wait-handler branch June 3, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rubenhoenle rubenhoenle rubenhoenle approved these changes

Assignees

No one assigned

Labels

domain:CentralServices

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GokceGK @rubenhoenle