refac(cdn): Migrate to new SDK structure#1421
Open
Fyusel wants to merge 1 commit into
Open
Conversation
STACKITCLI-356 Signed-off-by: Alexander Dahmen <alexander.dahmen@inovex.de>
Fyusel
force-pushed
the
migrate-cdn-to-new-sdk-struct
branch
from
9711742 to
c5bf0f4
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
marceljk
reviewed
Jun 2, 2026
| --monthly-limit-bytes int Monthly limit in bytes for the CDN distribution | ||
| --optimizer Enable optimizer for the CDN distribution (paid feature). | ||
| --regions strings Regions in which content should be cached, multiple of: ["EU" "US" "AF" "SA" "ASIA"] (default []) | ||
| --regions strings Regions in which content should be cached, multiple of: ["EU" "US" "AF" "SA" "ASIA" "unknown_default_open_api"] (default []) |
Contributor
There was a problem hiding this comment.
I think we need a helper function, what avoids that the fallback enum is part of the input flag and description. Similar like this in Terraform
marceljk
reviewed
Jun 2, 2026
| cdn "github.com/stackitcloud/stackit-sdk-go/services/cdn/v1api" | ||
|
|
||
| "github.com/stackitcloud/stackit-cli/internal/pkg/config" | ||
| genericclient "github.com/stackitcloud/stackit-cli/internal/pkg/generic-client" |
Contributor
There was a problem hiding this comment.
Can't add a comment in the correct line here, but in the ConfigureClient, the useRegion param needs to be set from true to false. Otherwise the commands won't work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STACKITCLI-356
Description
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)