Skip to content

chore(ci): set top-level permissions on workflows#564

Open
arpitjain099 wants to merge 1 commit into
solidjs:mainfrom
arpitjain099:chore/workflow-permissions
Open

chore(ci): set top-level permissions on workflows#564
arpitjain099 wants to merge 1 commit into
solidjs:mainfrom
arpitjain099:chore/workflow-permissions

Conversation

@arpitjain099
Copy link
Copy Markdown

Each of these workflows runs without a top-level permissions: block, so its GITHUB_TOKEN inherits the repository (or org) default, which is frequently read/write for all scopes.

Setting contents: read explicitly on .github/workflows/dist-typecheck.yml, .github/workflows/test.yml keeps the workflow token scoped to what the job actually uses. If a third-party action or transitive dependency in the run were ever compromised, a read-only token limits the damage (no pushes, no releases, no token-backed writes). The change is mechanical and does not alter any step.

Set an explicit least-privilege permissions block so the workflow GITHUB_TOKEN is scoped to contents: read instead of inheriting the repository default.

Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 2, 2026

⚠️ No Changeset found

Latest commit: 142f7c0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant