feat(qihe): add qihe options config detection#226
Open
edragain2nd wants to merge 2 commits into
Open
Conversation
hongjr03
reviewed
Jun 4, 2026
| ) { | ||
| command.args(&qihe_config.run_args); | ||
| if run_paths.use_options_file { | ||
| command.args(["--options", QIHE_OPTIONS_RUN_PATH]); |
Member
There was a problem hiding this comment.
Could we define how auto-detected qihe-options.toml should interact with explicit vide.qihe.runArgs here, since runArgs can already contain --options or override storage.root via -c?
hongjr03
requested changes
Jun 4, 2026
Member
hongjr03
left a comment
hongjr03
left a comment
There was a problem hiding this comment.
Thanks so much for the PR! This impl looks good to me overall. I left one comment about a case we should consider before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implement parts of #205
storage.rootin qihe-options.toml now