ACL-1.2 Add Strata platform support to acl_update_test

[deva-arista]

acl_update_test deviations for vendor "ARISTA" was set for "sand" platform. Strata platform (e.g.
DCS-7050CX4M-48D8-F) is slower in updating ACL and requires new deviation acl_update_delay_factor.

This change adds the hardware_model_regex to differentiate between different ARISTA platforms.

• (M) feature/acl/otg_tests/acl_update_test/acl_update_test.go
  • Use effectiveMaxDroppedPackets based on maxDroppedPackets and ACLUpdateDelayFactor
• (M) feature/acl/otg_tests/acl_update_test/metadata.textproto
  • Add hardware_model_regex to existing Arista sand platform_exceptions entry.
  • Add new platform_exceptions deviation acl_update_delay_factor for strata (DCS-7050.*)
• (M) internal/cfgplugins/dut_initialize.go
  • Skip TCAM profile initialization for strata
• (M) proto/metadata.proto
  • Add acl_update_delay_factor deviation field (427).
• (M) proto/metadata_go_proto/metadata.pb.go
  • Regenerated from metadata.proto.
• (M) internal/deviations/deviations.go
  • Add ACLUpdateDelayFactor accessor.

[OpenConfigBot]

Pull Request Functional Test Report for #5520 / f4f091a

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		ACL-1.2: ACL Update (Make-before-break)
Cisco 8000E		ACL-1.2: ACL Update (Make-before-break)
Cisco XRd		ACL-1.2: ACL Update (Make-before-break)
Juniper ncPTX		ACL-1.2: ACL Update (Make-before-break)
Nokia SR Linux		ACL-1.2: ACL Update (Make-before-break)
Openconfig Lemming		ACL-1.2: ACL Update (Make-before-break)

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		ACL-1.2: ACL Update (Make-before-break)
Cisco 8808		ACL-1.2: ACL Update (Make-before-break)
Juniper PTX10008		ACL-1.2: ACL Update (Make-before-break)
Nokia 7250 IXR-10e		ACL-1.2: ACL Update (Make-before-break)

Help

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces support for Arista Strata platforms within the ACL update testing framework. By adding a configurable delay factor, the tests can now accommodate the slower ACL update performance characteristic of these specific hardware models, ensuring more reliable test execution across different Arista platforms.

Highlights

• Strata Platform Support: Added support for Arista Strata platforms in acl_update_test by introducing a new acl_update_delay_factor deviation to account for slower ACL update times.
• Configuration Enhancements: Updated metadata.textproto to include hardware_model_regex for better platform differentiation and configured the new delay factor for Strata devices.
• Code Adjustments: Modified acl_update_test.go to calculate effectiveMaxDroppedPackets using the new delay factor and updated dut_initialize.go to skip TCAM profile initialization for Strata models.
• Proto Updates: Extended metadata.proto with the acl_update_delay_factor field and regenerated the corresponding Go protobuf files.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new deviation, acl_update_delay_factor, to scale the maximum allowed dropped packets during ACL update tests on Arista devices. It updates the metadata proto, adds the deviation accessor, and configures the TCAM profile for DCS-7050. The review feedback highlights a critical issue in NewDUTHardwareInit where mutating the global aristaTcamProfileMap introduces side effects across tests, and suggests returning an empty string directly instead.

[gemini-code-assist]

Modifying the package-level global map aristaTcamProfileMap inside NewDUTHardwareInit introduces a side effect that persists across subsequent calls and tests. If a non-DCS-7050 device is initialized after a DCS-7050 device in the same test run, its FeatureACLCounters profile will incorrectly be empty.

Instead of mutating the global map, return an empty string directly when the feature is FeatureACLCounters and the model is DCS-7050.

Suggested change

	if strings.Contains(dut.Model(), "DCS-7050") {
	aristaTcamProfileMap[FeatureACLCounters] = ``
	}
	if feature == FeatureACLCounters && strings.Contains(dut.Model(), "DCS-7050") {
	return ""
	}