refactor: extract resolveInitialValues to shared utility#238
Merged
Conversation
Avoid creating a full MotionState instance in resolveSSRStyles just to get initial style values. Extract the variant resolution logic into a shared resolveInitialValues function in state/utils.ts, used by both MotionState constructor and the SSR directive path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveInitialValuesintostate/utils.tsas a shared function used by bothMotionStateconstructor and SSR directiveMotionStateinstantiation inresolveSSRStyles— now resolves initial variant values directlyresolveInitialLatestValuesmethod fromMotionStateclassTest plan
🤖 Generated with Claude Code