transformers: add host kernel boot parameters transformer#4502
Open
vyadavmsft wants to merge 1 commit into
Open
transformers: add host kernel boot parameters transformer#4502vyadavmsft wants to merge 1 commit into
vyadavmsft wants to merge 1 commit into
Conversation
Add a new transformer that applies custom kernel boot parameters to the host (Dom0) kernel cmdline and reboots to activate them. Register the transformer in mixin_modules so LISA's reflection-based factory can discover it at runtime. The transformer validates each name=value token before calling GrubConfig.set_kernel_cmdline_arg, then reboots the node with the configured timeout.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a deployment transformer that configures host kernel boot parameters through GrubConfig, reboots the node to activate them, and registers the transformer for runtime discovery.
Changes:
- Introduces
host_kernel_boot_parameterstransformer schema and implementation. - Parses and validates whitespace-separated
name=valuekernel parameter tokens. - Registers the transformer in
mixin_modules.py.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
lisa/transformers/host_kernel_boot_parameters.py |
Adds the new transformer that applies boot parameters and reboots the node. |
lisa/mixin_modules.py |
Imports the transformer so the reflection factory can discover it. |
✅ AI Test Selection — PASSED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
Test case details
|
LiliDeng
reviewed
Jun 2, 2026
| f"Rebooting after setting host kernel boot parameters " | ||
| f"(timeout: {runbook.reboot_timeout}s)" | ||
| ) | ||
| self._node.reboot(time_out=runbook.reboot_timeout) |
Collaborator
There was a problem hiding this comment.
Should we check whether the parameters are set properly?
Collaborator
|
Write the doc for the transformer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new transformer that applies custom kernel boot parameters to the host (Dom0) kernel cmdline and reboots to activate them.
Register the transformer in mixin_modules so LISA's reflection-based factory can discover it at runtime.
The transformer validates each name=value token before calling GrubConfig.set_kernel_cmdline_arg, then reboots the node with the configured timeout.
Description
Related Issue
Type of Change
Checklist
Test Validation
Key Test Cases:
Impacted LISA Features:
Tested Azure Marketplace Images:
Test Results