Add lisa runbook generator prompt, reduce the size of test writer prompt#4476
Open
paxue wants to merge 5 commits into
Open
Add lisa runbook generator prompt, reduce the size of test writer prompt#4476paxue wants to merge 5 commits into
paxue wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new GitHub prompt for generating LISA runbook YAML and trims the existing LISA test-writer prompt to be shorter while keeping core guidance.
Changes:
- Reduced
.github/prompts/lisa_test_writer.prompt.mdfrom a long guide to a condensed checklist + skeleton. - Added
.github/prompts/lisa_runbook_generator.prompt.mdwith runbook structure, platform/testcase examples, and common scenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 11 comments.
| File | Description |
|---|---|
| .github/prompts/lisa_test_writer.prompt.md | Condenses test-writing guidance and keeps a short example skeleton. |
| .github/prompts/lisa_runbook_generator.prompt.md | Introduces a runbook-YAML generator prompt with examples and rules. |
LiliDeng
reviewed
May 12, 2026
reduce the lisa_test_writer prompt file
paxue
force-pushed
the
paxue/add_yaml_generator
branch
from
1c7e981 to
d699c67
Compare
LiliDeng
reviewed
May 21, 2026
| 1. **What tests?** (specific test name, area, smoke, tier — or passed via CLI variable) | ||
| 2. **What platform?** (azure, ready, qemu, openvmm) | ||
| 3. **What images?** (see Image Formats below) | ||
| 4. **Special requirements?** (security profile, WSL, purchase plan, disk/NIC) |
Collaborator
There was a problem hiding this comment.
Add the questions about azure auth
LiliDeng
reviewed
May 21, 2026
| **VHD** — custom OS disk from a storage blob URL: | ||
| ```yaml | ||
| vhd: | ||
| vhd_path: "https://mystorageaccount.blob.core.windows.net/vhds/my-image.vhd" |
Collaborator
There was a problem hiding this comment.
need specify the vhd generation and architecture, also need to mention when use arm64 vhd, either use shared gallery image or use gallery image transformer.
LiliDeng
reviewed
May 21, 2026
LiliDeng
reviewed
May 21, 2026
| platform: | ||
| - type: azure | ||
| admin_username: $(admin_username) | ||
| admin_password: $(admin_password) |
Collaborator
There was a problem hiding this comment.
encourage to use admin_private_key_file or leave it empty, lisa will generate the key pairs during runtime.
LiliDeng
reviewed
May 21, 2026
| | Azure Linux 3 | `microsoftcblmariner azure-linux-3 azure-linux-3 latest` | | ||
| | Debian 12 Gen2 | `debian debian-12 12-gen2 latest` | | ||
| | SLES 15 SP6 Gen2 | `suse sles-15-sp6 gen2 latest` | | ||
| | Windows Server 2022 Gen2 | `MicrosoftWindowsServer WindowsServer 2022-datacenter-g2 latest` | |
Collaborator
There was a problem hiding this comment.
when use windows image, is_linux needs to be set as false
Collaborator
Author
There was a problem hiding this comment.
Windows Server 2022 Gen2 image is major used for WSL, not for windows test.
In \lisa\lisa\sut_orchestrator\azure\platform_.py, there is logic to fill the is_linux auto from Marketplace image:
lisa/lisa/sut_orchestrator/azure/platform_.py
Lines 1649 to 1656 in 79657e5
LiliDeng
reviewed
May 21, 2026
| |---------|---------| | ||
| | `name` | Descriptive run name | | ||
| | `include` | Inherit from other YAML files: `- path: ./azure.yml` | | ||
| | `extension` | Extra test module paths: `- "../testsuites"` | |
Collaborator
There was a problem hiding this comment.
This needs to be expanded, when I use the prompt, it doesn't generate the section.
LiliDeng
reviewed
May 21, 2026
| | `name` | Descriptive run name | | ||
| | `include` | Inherit from other YAML files: `- path: ./azure.yml` | | ||
| | `extension` | Extra test module paths: `- "../testsuites"` | | ||
| | `variable` | Parameters with `$(name)` substitution. Supports `is_secret: true`, `file: ./secrets.yml` | |
Collaborator
There was a problem hiding this comment.
need to add is_case_visible
This reverts commit d699c67.
This reverts commit 607828b.
Comment on lines
+60
to
+65
| > shared_image_gallery: | ||
| > subscription_id: "$(subscription_id)" | ||
| > resource_group_name: "my-rg" | ||
| > image_gallery: "myGallery" | ||
| > image_definition: "myArm64ImageDef" # definition must have architecture=Arm64 | ||
| > image_version: "latest" |
Comment on lines
+84
to
+88
| > Then reference `$(shared_gallery)` in the platform `shared_image_gallery` field. | ||
|
|
||
| **Shared Image Gallery (SIG)** — image from Azure Compute Gallery: | ||
| ```yaml | ||
| shared_image_gallery: |
LiliDeng
reviewed
Jun 2, 2026
| vhd: | ||
| vhd_path: "https://mystorageaccount.blob.core.windows.net/vhds/my-image.vhd" | ||
| hyperv_generation: 2 # 1 or 2; required for correct VM generation selection | ||
| architecture: x64 # x64 or Arm64 |
Collaborator
There was a problem hiding this comment.
we can only use x64 when use vhd format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Type of Change
Checklist
Test Validation
Key Test Cases:
Impacted LISA Features:
Tested Azure Marketplace Images:
Test Results