Skip to content

Fixing UntypedNode sub json#95

Open
wisamidris77 wants to merge 5 commits into
microsoft:mainfrom
wisamidris77:main
Open

Fixing UntypedNode sub json#95
wisamidris77 wants to merge 5 commits into
microsoft:mainfrom
wisamidris77:main

Conversation

@wisamidris77
Copy link
Copy Markdown
Contributor

@wisamidris77 wisamidris77 commented Mar 3, 2025

UntypedNode like UntypedString the result like this "value":{"value":"jo"} instead of "value":"jo"
Before the changes

00:00 +37 -1: test\json_serialization_writer_test.dart: writeUntypedNode [E]
  Expected: '{"fieldName":"name","operator":"contains","value":"jo"}'
    Actual: '{"fieldName":"name","operator":"contains","value":{"value":"jo"}}'
     Which: is different.
            Expected: ... ","value":"jo"}
              Actual: ... ","value":{"value":" ...
                                    ^
             Differ at offset 50

  package:matcher                                 expect
  test\json_serialization_writer_test.dart 186:5  main.<fn>

After

Built test:test.
00:01 +38: All tests passed!

@wisamidris77 wisamidris77 requested a review from a team as a code owner March 3, 2025 23:15
@wisamidris77
Copy link
Copy Markdown
Contributor Author

Just copied the wrong output

Copy link
Copy Markdown
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Copy link
Copy Markdown
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@baywet baywet enabled auto-merge (squash) March 4, 2025 18:25
@baywet
Copy link
Copy Markdown
Member

baywet commented Mar 5, 2025

@wisamidris77 for this one the CI is failing, would you mind having a look when you have a couple of minutes please?

@ricardoboss
Copy link
Copy Markdown
Contributor

ricardoboss commented Sep 15, 2025

I think this can be closed. #97 should fix this already. Can you confirm @wisamidris77?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants