fix: keep first duplicate declarative template assignment#7556
Open
janechu wants to merge 2 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
<f-template>publishers with the samenameto keep the first resolved declarative template assignment instead of rejecting the definition.👩💻 Reviewer Notes
Please focus review on the first-publisher semantics for duplicate
<f-template>names and the new declarative fixture coverage.📑 Test Plan
npm run checkchange -- --branch origin/releases/fast-element-v3 --no-fetchnpm run build(validation agent reported passed)npm run biome:check(validation agent reported passed)✅ Checklist
General
$ npm run change