MAINT: Remove redundant PromptTarget from OpenAI target subclasses#1882
Open
hannahwestra25 wants to merge 2 commits into
Open
Conversation
OpenAITarget already inherits from PromptTarget, so listing PromptTarget explicitly in the bases of OpenAIChatTarget, OpenAIResponseTarget, and RealtimeTarget is redundant. Drop the duplicate base and the now-unused import in each file. No behavior change; all three classes remain subclasses of PromptTarget via OpenAITarget. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
romanlutz
approved these changes
Jun 1, 2026
adrian-gavrila
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OpenAITarget already inherits from PromptTarget, so listing PromptTarget explicitly in the bases of OpenAIChatTarget, OpenAIResponseTarget, and RealtimeTarget is redundant. This PR removes the duplicate base class and the now-unused
from pyrit.prompt_target.common.prompt_target import PromptTargetimport in each file.Changes
pyrit/prompt_target/openai/openai_chat_target.py:class OpenAIChatTarget(OpenAITarget, PromptTarget)->class OpenAIChatTarget(OpenAITarget)pyrit/prompt_target/openai/openai_response_target.py:class OpenAIResponseTarget(OpenAITarget, PromptTarget)->class OpenAIResponseTarget(OpenAITarget)pyrit/prompt_target/openai/openai_realtime_target.py:class RealtimeTarget(OpenAITarget, PromptTarget)->class RealtimeTarget(OpenAITarget)Behavior change
None. All three classes remain subclasses of
PromptTargetviaOpenAITarget(verified withissubclassfor each class).