Skip to content

Feature/dev live reload#322

Open
johnjansen wants to merge 26 commits into
martenframework:mainfrom
johnjansen:feature/dev-live-reload
Open

Feature/dev live reload#322
johnjansen wants to merge 26 commits into
martenframework:mainfrom
johnjansen:feature/dev-live-reload

Conversation

@johnjansen
Copy link
Copy Markdown

No description provided.

johnjansen and others added 25 commits September 6, 2025 08:33
- Add LiveReload middleware for injecting WebSocket client script
- Add live reload settings to GlobalSettings
- Update server to start live reload server in development mode
- Fix WebSocket client handling in live reload server
- Add comprehensive tests for live reload functionality
- Update middleware test to match SSE implementation
- Add handler tests for SSE endpoint
- Fix server tests for file watching
- Update deprecated sleep calls to use Time::Span
- Fix event handler reassignment in live reload script
- Update middleware test to use call instead of chain
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ellmetha
Copy link
Copy Markdown
Member

ellmetha commented Nov 6, 2025

Hey! 👋

Thanks a lot for opening this PR! I agree that live reloading could be useful for some Marten projects. However, I’m not sure it’s something that should live within the framework itself — many projects can (and do) use external tools for live- or hot-reloading, and the need might not be common enough to justify maintaining it as part of Marten.

I think it would make a great standalone shard though. Would you be open to creating one?

@johnjansen
Copy link
Copy Markdown
Author

[jj.monitor] Branch is 106 commits behind main and has substantive conflicts — 12 files diverged including src/marten/server.cr, src/marten/conf/global_settings.cr, and several middleware/handler files that have likely been rewritten upstream since Sep 2025.

The 14 failing CI checks (crystal, generated-project, postgres matrix, generated-auth-project) are downstream of the staleness, not all independent issues — they need re-running against a freshly-rebased branch before they're meaningful signal. Recommend rebasing onto current main in a worktree and pushing, then triaging whatever still fails.

[ƒ:kx7]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants