Skip to content

test: make instance projections implicit-reducible by default#13919

Draft
datokrat wants to merge 29 commits into
defeq_todo_4_paul_nwmfrom
paul/implicit-inst-proj
Draft

test: make instance projections implicit-reducible by default#13919
datokrat wants to merge 29 commits into
defeq_todo_4_paul_nwmfrom
paul/implicit-inst-proj

Conversation

@datokrat
Copy link
Copy Markdown
Contributor

@datokrat datokrat commented Jun 1, 2026

No description provided.

datokrat and others added 28 commits May 29, 2026 17:38
…tions

This PR adds `implicit_reducible` and/or `expose` attributes to definitions
that need to be unfolded during defeq checking without full transparency.
Preparatory commit for removing the TODO workaround in ExprDefEq.lean.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
 (#13584)

This PR fixes some warnings in stage2 due to redundant `@[expose]`.
This reverts commit cc007d9.
This reverts commit d74fd4a.
snapshot (failing)

snapshot (succeeding, Init.Prelude still having too many instance_reducible attributes)

done
@datokrat datokrat changed the base branch from master to defeq_todo_4_paul_nwm June 1, 2026 18:30
@datokrat
Copy link
Copy Markdown
Contributor Author

datokrat commented Jun 1, 2026

!radar

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Jun 1, 2026

Benchmark results for 35ba0b2 against bc527c4 are in. There are significant results. @datokrat

  • 🟥 build//instructions: +1.5G (+0.01%)
  • 🟥 other exited with code 1

Small changes (1🟥)

  • 🟥 build/module/Init.Data.Array.Attach//instructions: +35.6M (+0.34%)

@github-actions github-actions Bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 1, 2026
@leanprover-bot
Copy link
Copy Markdown
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2026-05-28 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2026-06-01 19:23:34)

@datokrat datokrat force-pushed the defeq_todo_4_paul_nwm branch from d5f7bfb to 89bf42e Compare June 2, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants