Skip to content

Sync out: LLM Module#171

Open
s2t2 wants to merge 2 commits into
google:copybara_pushfrom
s2t2:sync-out-llm
Open

Sync out: LLM Module#171
s2t2 wants to merge 2 commits into
google:copybara_pushfrom
s2t2:sync-out-llm

Conversation

@s2t2
Copy link
Copy Markdown
Collaborator

@s2t2 s2t2 commented Jun 1, 2026

This PR cherry picks LLM module content from the dirty sync branch.

All these LLM module files are new to the GitHub repo, so there are no conflicts and the module can be merged cleanly.

NOTE: there are lots of in progress internal changes and updates coming for this LLM module content.

NOTE: we see there are some formatting discrepancies between the internal Google code and what the formatting tools want to do (as reflected in the second commit in this branch).

FYI, here were the commands used:

# update local repos to track remote repos / update fork:
git fetch upstream
git fetch origin

# create a clean new branch:
git checkout -b sync-out-llm

# copy a specific file / directory from dirty sync branch to this branch:
git checkout upstream/internal_2026_38_15_11_5_2 -- smart_control/llm

# make a commit and bypass hooks:
git commit -m "Cherry pick LLM module from dirty sync branch" --no-verify

# run the formatter:
make format

# make a second commit to show what the formatting changes were made:
git commit -m "Format files"  --no-verify

Notes

It looks like the pre-commit hooks made some undesired changes, like:

-from collections.abc import Mapping, Sequence
+from collections.abc import Mapping
+from collections.abc import Sequence

And there are still some pylint issues that need to be addressed (or most likely the tooling needs fixing / relaxing)

(.venv) mjrossetti@mjrossetti:~/projects/sbsim$ git commit -m "Format files"
pyink....................................................................Passed
isort....................................................................Passed
pylint...................................................................Failed
- hook id: pylint
- exit code: 20

************* Module generator
smart_control/llm/prompts/generator.py:46:7: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)

************* Module control_loop_test
smart_control/llm/loop/control_loop_test.py:1:0: C0114: Missing module docstring (missing-module-docstring)

************* Module schedule_tool_test
smart_control/llm/utils/schedule_tool_test.py:1:0: C0114: Missing module docstring (missing-module-docstring)

************* Module default_agent_test
smart_control/llm/agents/default_agent_test.py:1:0: C0114: Missing module docstring (missing-module-docstring)

************* Module promptmaker_test
smart_control/llm/prompts/promptmaker_test.py:1:0: C0114: Missing module docstring (missing-module-docstring)

************* Module base_agent_test
smart_control/llm/agents/base_agent_test.py:1:0: C0114: Missing module docstring (missing-module-docstring)

************* Module llm_agent_test
smart_control/llm/agents/llm_agent_test.py:1:0: C0114: Missing module docstring (missing-module-docstring)
smart_control/llm/agents/llm_agent_test.py:228:0: C0115: Missing class docstring (missing-class-docstring)
smart_control/llm/agents/llm_agent_test.py:376:47: W0613: Unused argument 'mock_sleep' (unused-argument)
smart_control/llm/agents/llm_agent_test.py:404:52: W0613: Unused argument 'mock_sleep' (unused-argument)
smart_control/llm/agents/llm_agent_test.py:451:50: W0613: Unused argument 'mock_sleep' (unused-argument)
smart_control/llm/agents/llm_agent_test.py:478:12: W0613: Unused argument 'mock_sleep' (unused-argument)
smart_control/llm/agents/llm_agent_test.py:519:12: W0613: Unused argument 'mock_sleep' (unused-argument)

************* Module action_context_test
smart_control/llm/schema/action_context_test.py:1:0: C0114: Missing module docstring (missing-module-docstring)

************* Module action_context
smart_control/llm/schema/action_context.py:203:0: C0325: Unnecessary parens after 'not' keyword (superfluous-parens)

************* Module sb1_promptmaker_test
smart_control/llm/prompts/sb1/sb1_promptmaker_test.py:1:0: C0114: Missing module docstring (missing-module-docstring)

************* Module schedule_agent_test
smart_control/llm/agents/schedule_agent_test.py:1:0: C0114: Missing module docstring (missing-module-docstring)

************* Module floor_based_promptmaker_test
smart_control/llm/prompts/floor_based_promptmaker_test.py:1:0: C0114: Missing module docstring (missing-module-docstring)

************* Module conftest
smart_control/llm/services/conftest.py:55:25: W0613: Unused argument 'prompt' (unused-argument)

************* Module base_promptmaker_test
smart_control/llm/prompts/base_promptmaker_test.py:1:0: C0114: Missing module docstring (missing-module-docstring)

@s2t2 s2t2 changed the title Sync out: LLM Sync out: LLM Module Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant