storage: discard checksum corrupt chunks on startup#11886
Conversation
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
📝 WalkthroughWalkthroughThe PR extends storage chunk error handling to treat checksum corruption ( ChangesChecksum Error Irrecoverability
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #11847.
Upgrade to chunkio v1.5.5 and fix interfaces:
When filesystem storage finds a chunk with a bad checksum during startup scan/backlog loading, treat it as irrecoverable when
storage.delete_irrecoverable_chunksis enabled.This updates the storage backlog path to discard checksum-corrupt chunks, matching ChunkIO's irrecoverable-chunk handling, and adds an in_tail integration test covering startup cleanup.
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.