feat: Variant parameters#2469
Open
trisyoungs wants to merge 17 commits into
Open
Conversation
trisyoungs
force-pushed
the
dissolve2/reinstate-ff-tests
branch
from
4a24122 to
d04647f
Compare
trisyoungs
force-pushed
the
dissolve2/reinstate-ff-tests
branch
from
d04647f to
1c14170
Compare
…rovidesDataType().
trisyoungs
force-pushed
the
dissolve2/variant-parameters
branch
from
fffbeb7 to
f3887d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to allow
std::variantas a workableParameterdata type, driven from the need to useSetCellNodeto work on bothConfigurations as well asStructures. To neaten things up at the end I introducedVariantParameterData(seenodes/parameter.h) to tidy things up and force the use ofstd::monostateas the first alternative in the variant.TODO
std::variant-basedParametercurrently fails - needs a refactor to be able to switch to using a setter on the variant (source)Parameterrather than a getter from the destinationParameter.std::variantcan be empty?