Skip to content

BIP174: Clarify proprietary fields are retained on finalization#2183

Merged
jonatack merged 1 commit into
bitcoin:masterfrom
evanlinjin:fix/174-explicitly-mention-proprietary-fields-as-unknown
May 30, 2026
Merged

BIP174: Clarify proprietary fields are retained on finalization#2183
jonatack merged 1 commit into
bitcoin:masterfrom
evanlinjin:fix/174-explicitly-mention-proprietary-fields-as-unknown

Conversation

@evanlinjin
Copy link
Copy Markdown
Contributor

@evanlinjin evanlinjin commented May 30, 2026

Note that the Input Finalizer retains PSBT_IN_PROPRIETARY fields it does not understand, treating them like unknown fields so it does not clear proprietary data it cannot interpret.

@evanlinjin
Copy link
Copy Markdown
Contributor Author

This version has proprietary fields mentioned as a separate category than unknown fields.

The other option is:

All other data except the UTXO and unknown fields (including PSBT_IN_PROPRIETARY fields the Input Finalizer does not understand) in the input key-value map should be cleared from the PSBT. The UTXO should be kept to allow Transaction Extractors to verify the final network serialized transaction.

@achow101
Copy link
Copy Markdown
Member

The other option is:

I prefer this

Note that the Input Finalizer retains PSBT_IN_PROPRIETARY fields it does
not understand, treating them like unknown fields so it does not clear
proprietary data it cannot interpret.
@evanlinjin evanlinjin force-pushed the fix/174-explicitly-mention-proprietary-fields-as-unknown branch from 011fff5 to a4668bb Compare May 30, 2026 08:04
@evanlinjin
Copy link
Copy Markdown
Contributor Author

@achow101 updated!

@achow101
Copy link
Copy Markdown
Member

ACK a4668bb

Copy link
Copy Markdown
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Are the clarifications here and #2182 worth a changelog note?)

@jonatack jonatack merged commit 1495b68 into bitcoin:master May 30, 2026
4 checks passed
@jonatack jonatack added the Proposed BIP modification PR by non-owner to update BIP content label May 30, 2026
@achow101
Copy link
Copy Markdown
Member

(Are the clarifications here and #2182 worth a changelog note?)

IMO No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Proposed BIP modification PR by non-owner to update BIP content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants