Update unsloth playbook setup and simplify pytorch dependency#320
Open
lucbruni-amd wants to merge 1 commit into
Open
Update unsloth playbook setup and simplify pytorch dependency#320lucbruni-amd wants to merge 1 commit into
lucbruni-amd wants to merge 1 commit into
Conversation
- Add render/video group prerequisite for non-reference devices - Remove redundant pip installs (unsloth-zoo, timm, datasets, transformers, trl) already pulled transitively by unsloth[amd] - Remove python3-venv install from halo_box (pre-installed) - Drop rocm from @require tag (torch install sufficient for this playbook) - Simplify pytorch.md install commands (remove --upgrade pip, --force-reinstall) - Code-highlight bitsandbytes in cautionary note
lucbruni-amd
requested review from
adamlam2-amd,
danielholanda,
harkgill-amd and
sreeram-11
sreeram-11
approved these changes
Jun 1, 2026
Collaborator
|
Please wait for @adamlam2-amd 's review before merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unsloth-zoo,timm,datasets,transformers,trl) — already pulled transitively byunsloth[amd]python3-venvinstall from halo_box (pre-installed)rocmfrom@requiretag —torch torchvision torchaudioinstall is sufficient for this playbook (pullsrocm[libraries]transitively;rocm[devel]not needed)pytorch.mdinstall commands (remove--upgrade pip,--force-reinstall,--no-cache-dir)bitsandbytesin cautionary note