Skip to content

fix: sandbox run is only interactive#427

Merged
MichaelGoberling merged 1 commit into
masterfrom
feat/runtime-sandbox-run-2
Jun 4, 2026
Merged

fix: sandbox run is only interactive#427
MichaelGoberling merged 1 commit into
masterfrom
feat/runtime-sandbox-run-2

Conversation

@MichaelGoberling
Copy link
Copy Markdown
Contributor

Oops... Forgot to push before merging the original PR

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 PR Reviewer

This diff removes the one-shot -- <command> execution mode and enforces interactive-only use with a TTY check. The changes are clean, well-tested, and correctly guard against non-TTY stdin. The new _failUsage helper writes directly to stderr and sets process.exitCode rather than throwing, which is appropriate for usage errors that should not be treated as unexpected failures.

LGTM! This PR looks good to merge.


💡 How to re-trigger

Comment /review or /pr-reviewer on this PR

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@MichaelGoberling MichaelGoberling merged commit 7697d04 into master Jun 4, 2026
11 checks passed
@MichaelGoberling MichaelGoberling deleted the feat/runtime-sandbox-run-2 branch June 4, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant