ci: remove dead --no-deps ternary in cargo doc step#5974
Merged
Conversation
The step's `if:` already gates on `inputs.nightly == 'true'`, so the
`${{ inputs.nightly != 'true' && '--no-deps' || '' }}` ternary always
evaluates to the empty string. Drop the dead expression and the now-stale
comment. Behavior is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
🗒️ Docstep intest-rust.yamlis gated oninputs.nightly == 'true', so the inline ternary${{ inputs.nightly != 'true' && '--no-deps' || '' }}always evaluates to the empty string —--no-depsis never appended.This is leftover from #4107, which tightened the step's
if:toinputs.nightly == 'true'but didn't update the args expression. The accompanying comment ("Only run with deps on nightly...") also no longer reflects behavior, since the step itself is now nightly-only.This is a cosmetic cleanup — behavior is unchanged.
Found by nightly survey of
.github/workflows/test-rust.yaml.