feat: Suggestions for the unified platform#282
Conversation
|
Bencher Report| Branch | unified-suggestions |
| Testbed | mhovd-pgx |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Upper Boundary (Limit %) |
|---|---|---|---|---|
| bimodal_ke_npag | Latency seconds (s) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 12.09 s(+157.30%)Baseline: 4.70 s | 6.39 s (189.09%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| bimodal_ke_npag | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 12,088.00 ms(+157.30%)Baseline: 4,698.06 ms | 6,392.73 ms (189.09%) |
| bimodal_ke_npod | 📈 view plot 🚷 view threshold | 1,516.20 ms(+13.64%)Baseline: 1,334.20 ms | 1,675.54 ms (90.49%) |
| bimodal_ke_postprob | 📈 view plot 🚷 view threshold | 522.31 ms(+110.76%)Baseline: 247.82 ms | 722.61 ms (72.28%) |
mhovd
changed the title
| .parameter(Parameter::bounded("h2r2", 10.0, 22.0))? | ||
| .method(Npag::new()) | ||
| .nonparametric() | ||
| .parameter(BoundedParameter::new("v1", 5.0, 160.0)) |
There was a problem hiding this comment.
I kinda prefer Parqameter::bounded() to BoundedParameter::new() as rust-analyzer's auto-completion will be a bit more helpful with the former.
Not very important tbh, as autocompletion will also trigger when writting Parameter and show all options.
| .error( | ||
| "outeq_1", | ||
| AssayErrorModel::proportional(ErrorPoly::new(0.1, 0.1, 0.0, 0.0), 1.0), | ||
| )? |
There was a problem hiding this comment.
I think .error() should return an error. If the user provides an outeq not listed in the model's metadata it should fail while constructing the problem and not during execuiton
| .unwrap() | ||
| .method(Npod::new()) | ||
| .nonparametric() | ||
| .parameter(BoundedParameter::new("cls", 0.1, 10.0)) |
There was a problem hiding this comment.
It is the same with parameter. I think it should return error, so we can detect errors in the name of the ranges when constructing the problem and not during execution
| let parameter_space = ParameterSpace::new() | ||
| .add(Parameter::bounded("ke", 0.001, 3.0)) | ||
| .add(Parameter::bounded("v", 25.0, 250.0)); | ||
| let parameter_space = NonParametricParameters::new() |
There was a problem hiding this comment.
NonParametricParameters is a fun word. Do we need a distinction between parametric and non parametric parameter spaces?
There was a problem hiding this comment.
Actually no, I can change it to be generic, which is more flexible and easier to use. Good suggestion!
| println!("Loading prior from bimodal_ke example..."); | ||
| let (theta, prior) = read_prior("examples/bimodal_ke/output/theta.csv", ¶meter_space)?; | ||
| let (theta, prior) = Theta::from_file( | ||
| &"examples/bimodal_ke/output/theta.csv".to_string(), |
2 participants
No description provided.