Skip to content

[Fixes #14274] Enable importing a remote resource from a private WMS service#14285

Merged
mattiagiupponi merged 9 commits into
masterfrom
ISSUE_14274
Jun 4, 2026
Merged

[Fixes #14274] Enable importing a remote resource from a private WMS service#14285
mattiagiupponi merged 9 commits into
masterfrom
ISSUE_14274

Conversation

@sijandh35
Copy link
Copy Markdown
Contributor

Fixes #14274

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Jun 1, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for authentication configurations when importing remote WMS services, updating serializers, thumbnail generation, and resource payload generation to handle credentials, alongside adding corresponding unit tests. The review feedback highlights several critical issues, including a potential runtime TypeError when instantiating AuthConfig with a non-field property, a potential DoesNotExist exception when fetching an authentication configuration, and potential ValueError exceptions if queries are performed with an unauthenticated or null user.

Comment thread geonode/upload/handlers/remote/wms.py Outdated
Comment thread geonode/upload/handlers/remote/wms.py Outdated
Comment thread geonode/upload/handlers/remote/wms.py Outdated
Comment thread geonode/upload/handlers/remote/wms.py Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

❌ Patch coverage is 86.18785% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.89%. Comparing base (91c4ec5) to head (d2c34bc).
⚠️ Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14285      +/-   ##
==========================================
- Coverage   74.92%   74.89%   -0.04%     
==========================================
  Files         975      977       +2     
  Lines       59902    60233     +331     
  Branches     8157     8213      +56     
==========================================
+ Hits        44884    45109     +225     
- Misses      13194    13299     +105     
- Partials     1824     1825       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sijandh35 sijandh35 marked this pull request as draft June 3, 2026 07:28
@sijandh35 sijandh35 marked this pull request as ready for review June 3, 2026 07:28
@mattiagiupponi mattiagiupponi merged commit a3d7793 into master Jun 4, 2026
16 of 17 checks passed
@mattiagiupponi mattiagiupponi deleted the ISSUE_14274 branch June 4, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable importing a remote resource from a private WMS service

2 participants