[rocSparse][AdaptiveCPP] Build issues with Sparse domain

[abagusetty]

Steps to reproduce:

cmake .. \
      -DCMAKE_C_COMPILER=acpp \
      -DCMAKE_CXX_COMPILER=acpp \
      -DONEMATH_SYCL_IMPLEMENTATION=hipsycl \
      -DAdaptiveCpp_DIR=${ACPP_HOME}/acpp/lib/cmake/AdaptiveCpp \
      -DENABLE_MKLGPU_BACKEND=False \
      -DENABLE_MKLCPU_BACKEND=False \
      -DENABLE_ROCBLAS_BACKEND=True \
      -DENABLE_ROCSOLVER_BACKEND=True \
      -DENABLE_ROCRAND_BACKEND=True \
      -DENABLE_ROCSPARSE_BACKEND=True \
      -DHIPSYCL_TARGETS=hip:gfx90a \
      -DBUILD_FUNCTIONAL_TESTS=False \
      -DBUILD_EXAMPLES=False \
      -DHIP_TARGETS=gfx90a \
      -DCMAKE_INSTALL_PREFIX=${ACPP_HOME}/onemath

Compiler Version: (AdaptiveCPP:v25.02.0)

acpp --version
AMD clang version 19.0.0git (https://github.com/RadeonOpenCompute/llvm-project roc-6.4.0 25133 c7fe45cf4b819c5991fe208aaa96edf142730f1d)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /opt/rocm-6.4.0/lib/llvm/bin
Configuration file: /opt/rocm-6.4.0/lib/llvm/bin/clang++.cfg

Error:

[  7%] Building CXX object bin/sparse_blas/backends/rocsparse/CMakeFiles/onemath_sparse_blas_rocsparse_obj.dir/rocsparse_handles.cpp.o
cd /lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/oneMath/build-acpp-rocm6.4.0/bin/sparse_blas/backends/rocsparse && /lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/acpp_install-6.4.0_05282025/acpp/bin/acpp -DUSE_PROF_API=1 -D__HIP_PLATFORM_AMD__=1 -I/lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/oneMath/include -I/lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/oneMath/build-acpp-rocm6.4.0/bin -I/lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/oneMath/src/include -I/lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/oneMath/src -isystem /opt/rocm-6.4.0/include -O3 -DNDEBUG -std=gnu++17 -fPIC -Wall -Wextra -Wshadow -Wconversion -Wpedantic -MD -MT bin/sparse_blas/backends/rocsparse/CMakeFiles/onemath_sparse_blas_rocsparse_obj.dir/rocsparse_handles.cpp.o -MF CMakeFiles/onemath_sparse_blas_rocsparse_obj.dir/rocsparse_handles.cpp.o.d -o CMakeFiles/onemath_sparse_blas_rocsparse_obj.dir/rocsparse_handles.cpp.o -c /lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/oneMath/src/sparse_blas/backends/rocsparse/rocsparse_handles.cpp
In file included from /lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/oneMath/src/sparse_blas/backends/rocsparse/rocsparse_handles.cpp:20:
In file included from /lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/oneMath/include/oneapi/math/sparse_blas/detail/rocsparse/onemath_sparse_blas_rocsparse.hpp:25:
In file included from /lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/oneMath/include/oneapi/math/sparse_blas/types.hpp:23:
In file included from /lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/oneMath/include/oneapi/math/types.hpp:30:
/lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/oneMath/include/oneapi/math/bfloat16.hpp:67:36: warning: implicit conversion loses integer precision: 'int' to 'std::uint16_t' (aka 'unsigned short') [-Wimplicit-int-conversion]
   67 |     bfloat16(int raw_, bool) : raw(raw_) {}
      |                                   ~^~~~
/lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/oneMath/include/oneapi/math/bfloat16.hpp:222:44: warning: implicit conversion changes signedness: 'int' to 'std::uint32_t' (aka 'unsigned int') [-Wsign-conversion]
  222 |     return bfloat16_impl::raw_to_float(raw << 16);
      |            ~~~~~~~~~~~~~               ~~~~^~~~~
In file included from /lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/oneMath/src/sparse_blas/backends/rocsparse/rocsparse_handles.cpp:22:
In file included from /lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/oneMath/src/sparse_blas/backends/rocsparse/rocsparse_error.hpp:25:
In file included from /opt/rocm-6.4.0/include/hip/hip_runtime.h:70:
/opt/rocm-6.4.0/include/hip/hip_runtime_api.h:1172:16: error: redefinition of 'dim3'
 1172 | typedef struct dim3 {
      |                ^
/lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/acpp_install-6.4.0_05282025/acpp/bin/../include/AdaptiveCpp/hipSYCL/pcuda/detail/dim3.hpp:16:8: note: previous definition is here
   16 | struct dim3 {
      |        ^
In file included from /lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/oneMath/src/sparse_blas/backends/rocsparse/rocsparse_handles.cpp:23:
In file included from /lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/oneMath/src/sparse_blas/backends/rocsparse/rocsparse_helper.hpp:31:
/lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/oneMath/src/sparse_blas/sycl_helper.hpp:58:13: error: no member named 'host_task' in 'hipsycl::sycl::handler'
   58 |         cgh.host_task([=]() { delete ptr; });
      |         ~~~ ^
/lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/oneMath/src/sparse_blas/sycl_helper.hpp:74:13: error: no member named 'host_task' in 'hipsycl::sycl::handler'
   74 |         cgh.host_task([=]() {});
      |         ~~~ ^
In file included from /lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/oneMath/src/sparse_blas/backends/rocsparse/rocsparse_handles.cpp:25:
/lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/oneMath/src/sparse_blas/backends/rocsparse/rocsparse_scope_handle.hpp:56:5: error: unknown type name 'HIPcontext'
   56 |     HIPcontext original_;
      |     ^
/lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/oneMath/src/sparse_blas/backends/rocsparse/rocsparse_scope_handle.hpp:63:52: error: use of undeclared identifier 'pi_context'
   63 |     static thread_local rocsparse_handle_container<pi_context> handle_helper;
      |                                                    ^
/lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/oneMath/src/sparse_blas/backends/rocsparse/rocsparse_scope_handle.hpp:81:52: error: no member named 'ext_oneapi_hip' in 'hipsycl::rt::backend_id'
   81 |     auto hipPtr = ih.get_native_mem<sycl::backend::ext_oneapi_hip>(acc);
      |                                     ~~~~~~~~~~~~~~~^
In file included from /lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/oneMath/src/sparse_blas/backends/rocsparse/rocsparse_handles.cpp:26:
In file included from /lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/oneMath/src/sparse_blas/backends/rocsparse/rocsparse_task.hpp:24:
/lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/oneMath/src/sparse_blas/backends/common_launch_task.hpp:70:9: error: no member named 'host_task' in 'hipsycl::sycl::handler'
   70 |     cgh.host_task([functor, queue, capture_only_accessors...](sycl::interop_handle ih) {
      |     ~~~ ^
/lustre/orion/csc613/scratch/abagusetty/SYCL_compilers_05282025/oneMath/src/sparse_blas/backends/common_launch_task.hpp:88:9: error: no member named 'host_task' in 'hipsycl::sycl::handler'
   88 |     cgh.host_task(
      |     ~~~ ^
2 warnings and 8 errors generated.

[illuhad]

/opt/rocm-6.4.0/include/hip/hip_runtime_api.h:1172:16: error: redefinition of 'dim3'

This particular issue is known and already fixed on AdaptiveCpp's develop branch. AdaptiveCpp has recently added native support for the CUDA/HIP languages in input code, so explicitly pulling in those symbols from CUDA or HIP headers can cause multiple definitions to occur.
As I said, it's fixed on develop branch and should be fixed by updating your AdaptiveCpp.

The other issue seems to be the use of host_task which AdaptiveCpp does not support because it's almost always a performance anti-pattern.

[nilsfriess]

The other issue seems to be the use of host_task which AdaptiveCpp does not support because it's almost always a performance anti-pattern.

It seems that's not the only issue (and it's not a big issue either, other backends also use host_task but have ifdefs for AdaptiveCpp and then use enqueue_custom_operation instead).

The bigger issue is that the rocSparse backend (also the rocSolver backend) uses some types that don't exist in AdaptiveCpp, namely pi_context or ur_context_handle_t, see e.g. here. I googled and it brought up that those come from the oneAPI Unified Runtime (I have no idea what that is) so I don't think there's any hope to make the rocSparse backend work with AdaptiveCpp which is very unfortunate.

Edit: Seems like #685 fixes an issue regarding these types, so maybe it's not true what I said.

[illuhad]

The bigger issue is that the rocSparse backend (also the rocSolver backend) uses some types that don't exist in AdaptiveCpp, namely pi_context or ur_context_handle_t, see e.g. here. I googled and it brought up that those come from the oneAPI Unified Runtime (I have no idea what that is) so I don't think there's any hope to make the rocSparse backend work with AdaptiveCpp which is very unfortunate.

Yes, these are internal DPC++ types, however, we have the exact same code patterns in the rocBLAS backend for the blas domain, which does support AdaptiveCpp:

https://github.com/uxlfoundation/oneMath/blob/b03aa80d96a1725b3bda040a7b4f4de85a270f6c/src/blas/backends/rocblas/rocblas_scope_handle.hpp

The key bit is there, there's also an AdaptiveCpp-specific header which I assume is included instead of this one when using AdaptiveCpp:
https://github.com/uxlfoundation/oneMath/blob/b03aa80d96a1725b3bda040a7b4f4de85a270f6c/src/blas/backends/rocblas/rocblas_scope_handle_hipsycl.hpp

I imagine a similar approach might also work for lapack/rocSparse.

[nilsfriess]

I imagine a similar approach might also work for lapack/rocSparse.

Yes you're right, it was pretty simple to adapt.