fix(app): show MCP and LSP status by fetching directly in status UI#30259
Closed
OpeOginni wants to merge 2 commits into
Closed
fix(app): show MCP and LSP status by fetching directly in status UI#30259OpeOginni wants to merge 2 commits into
OpeOginni wants to merge 2 commits into
Conversation
Contributor
Author
|
hey @Hona are you able to check this out to fix the MCP issue folks are having? my bad, just saw your fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #30228
Closes #30125
Closes #30099
Closes #30141
Closes #30070
Closes #30104
Closes #30222
Closes #30171
Closes #30159
Closes #30202
Closes #30130
Closes #30098
Closes #30330
Closes #30265
Type of change
What does this PR do?
The MCP selection dialog and status popover showed
0 of 0/ empty even when the/mcpendpoint correctly returned server statuses (including failed servers likegithubandjira).The UI read MCP/LSP state from the shared directory sync store (
sync.data.mcp/sync.data.lsp). After MCP loading was made lazy (only enabled for open directories), that store was often empty or stale when these components rendered, so statuses weren't shown.Solution
Fetch MCP and LSP status directly in the components that display them, using the existing directory-scoped SDK client:
dialog-select-mcp.tsxnow queriessdk.client.mcp.status().status-popover-body.tsxaddsuseMcpStatus()/useLspStatus()and reads from those live queries.Query keys stay aligned with the existing
[directory, "mcp"|"lsp"]cache keys.How did you verify your code works?
Screenshots / recordings
Checklist